Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zlib dep to Tkinter 2.x and 3.x #5926

Merged

Conversation

vanzod
Copy link
Member

@vanzod vanzod commented Feb 27, 2018

(created using eb --new-pr)

edit: follow-up for #5797

@vanzod vanzod requested a review from boegel February 27, 2018 19:50
@vanzod vanzod added this to the 3.5.2 milestone Feb 27, 2018
@vanzod vanzod added the bug fix label Feb 27, 2018
@boegel
Copy link
Member

boegel commented Feb 27, 2018

Test report by @boegel
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in this PR)
node2030.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/f923c3c7bdebdb408a0dda818392b8e7 for a full test report.

@boegel
Copy link
Member

boegel commented Feb 27, 2018

Test report by @boegel
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in this PR)
node2689.swalot.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/6bff006fbb90a12568e4068496bbecd1 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Feb 27, 2018

Going in, thanks @vanzod!

@boegel boegel merged commit 38b7cd5 into easybuilders:develop Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants