-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix checksums for pkgmaker/rngtools/RWeka/RcppProgress extensions in R 3.4.4 easyconfigs #6446
Conversation
…R 3.4.4 easyconfigs
I checked the differences between the old and the new tarballs:
|
Test report by @boegel |
Test report by @boegel |
@JoFAM Thoughts on this, how can this happen? |
@boegel For pkgmaker version 0.22 was the version on CRAN at the release of R3.5, and due to the drastic internal changes all packages needed to be https://cran.r-project.org/src/contrib/Archive/pkgmaker/ The new version (0.27) is released on may 25, but then the old version was already
edit: I was obviously clearly wrong here For RWeka it looks like CRAN or Kurt himself corrected the DOI link - they need to have the https:// etc in front. It's something I don't like, but it does happen more often that very small changes in the DESCRIPTION file are made without upping the version. |
@JoFAM How does rebuilding for a new R release affect source tarballs? That's just wrong imho... |
@boegel you're right, and eg pkgmaker doesn't even have compiled code. (shame on me!) Culprit seems to be the tools used. Afaik, CRAN uses gzip to create the tarballs, and gzip adds a timestamp of the creation of the tarball, which results in a different checksum even when the exact same folder is zipped at a different moment. See eg : https://serverfault.com/questions/110208/different-md5sums-for-same-tar-contents Looking at the time stamps on the server, it seems like the current version is repackaged on may 10, 2018. I'll check with the powers-that-be if that could epxlain this and if there's any chance of preventing this from happening in the future. |
Please do, because this is getting really annoying, and it looks bad imho, checksums for released source tarballs should never change... |
Done : https://stat.ethz.ch/pipermail/r-package-devel/2018q2/002813.html I got answer from one of the CRAN maintainers in the meantime. The habit of changing description files in releases is unlikely to change soon. I've asked if there's a possibility to at least avoid checksum changes when archiving. You can follow the discussion using the web interface if you like. Keep in mind there's a little delay on the archive compared to the actual mailing list. |
Thanks a lot for raising this @JoFAM! Even changing the descriptions should result in some kind of version bump imho, for example with an additional digit in the version number like |
@boegel I wholeheartedly agree, but I'm afraid I don't carry enough weight to make that change happen... |
No idea what happened, but when downloading the following files from CRAN now, the checksums are different than before.
That's strange, especially for
pkgmaker_0.22.tar.gz
andrngtools_1.2.4.tar.gz
, both of which were downloaded on Jan 16th 2015 and haven't changed since (until now, that is).