Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch to Python 3.6.1 - 3.6.3 that removes comment in comment. #6946

Conversation

akesandgren
Copy link
Contributor

The patch matches the code from Python 3.6.4 and reduces the problem with building hashlib.

Also ran --inject-checksum --force causing exts_list to get a lot of changes.

The patch matches the code from Python 3.6.4 and reduces the problem with building hashlib.

Also ran --inject-checksum --force causing exts_list to get a lot of changes.
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added the bug fix label Oct 2, 2018
@boegel boegel added this to the 3.7.1 milestone Oct 2, 2018
@boegel
Copy link
Member

boegel commented Oct 2, 2018

Test report by @boegel
FAILED
Build succeeded for 5 out of 9 (9 easyconfigs in this PR)
node2119.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/14e601bac95f181674ab0eeb456ab44d for a full test report.

@boegel
Copy link
Member

boegel commented Oct 3, 2018

Test report by @boegel
FAILED
Build succeeded for 21 out of 25 (9 easyconfigs in this PR)
node2582.golett.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/d07c79133190f35006e651955309cff2 for a full test report.

@boegel
Copy link
Member

boegel commented Oct 7, 2018

Test report by @boegel
SUCCESS
Build succeeded for 9 out of 9 (9 easyconfigs in this PR)
node2410.golett.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/97cacdaf6ea2b1f18736b0d3c97ef3c9 for a full test report.

@boegel
Copy link
Member

boegel commented Oct 7, 2018

Test report by @boegel
SUCCESS
Build succeeded for 9 out of 9 (9 easyconfigs in this PR)
node2063.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/3000a828307f154c2b29c41bb3e2104d for a full test report.

@boegel
Copy link
Member

boegel commented Oct 7, 2018

Going in, thanks @akesandgren!

@boegel boegel merged commit a0ee1ad into easybuilders:develop Oct 7, 2018
@akesandgren akesandgren deleted the fix-comment-in-comment-for-python-3.6.1-3.6.3 branch October 7, 2018 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants