Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[foss/2018b] PHANOTATE v20190724 #8667

Conversation

pescobar
Copy link
Member

@pescobar pescobar commented Aug 5, 2019

(created using eb --new-pr)

edit (by @boegel): requires fix from easybuilders/easybuild-framework#3537

@pescobar pescobar added the new label Aug 5, 2019
@pescobar
Copy link
Member Author

pescobar commented Aug 5, 2019

when downloading a git repo the checksum doesn't work but travis still complains. how should I proceed?

@boegel boegel added this to the 4.x milestone Dec 29, 2020
'url': 'https://github.com/deprekate',
'repo_name': 'PHANOTATE',
'commit': '%s' % git_commit,
'recursive': True,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, the installation of this is broken, because the current master of the PHANOTATE repo doesn't have submodules anymore.

So, the initial clone with git clone --recursive doesn't create a fastpath directory, and the subsequent git checkout cc42101 just leaves an empty fastpath directory.

The subsequent git submodule update doesn't do much, it seems like that should be git submodule update --init to ensure the submodule gets initialized first (so that needs to be fixed in framework).

@boegel boegel changed the title {bio}[foss/2018b] PHANOTATE v20190724-cc42101 {bio}[foss/2018b] PHANOTATE v20190724 Jan 2, 2021
@easybuilders easybuilders deleted a comment from boegelbot Jan 2, 2021
@boegel
Copy link
Member

boegel commented Jan 3, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3501.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/664b5427f616efb58c8e2cc7ac807639 for a full test report.

@boegel
Copy link
Member

boegel commented Jan 3, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=8667 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_8667 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12355

Test results coming soon (I hope)...

- notification for comment with ID 753591671 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/a4eafe7cfcdaf96627078aeafe44efb1 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jan 3, 2021

Going in, thanks @pescobar!

@boegel boegel merged commit 4542bf1 into easybuilders:develop Jan 3, 2021
@boegel
Copy link
Member

boegel commented Jan 3, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2631.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/4d0e52f3645685194b8e5bd05c9b83d5 for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.3.3?) Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants