-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bio}[foss/2018b] PHANOTATE v20190724 #8667
{bio}[foss/2018b] PHANOTATE v20190724 #8667
Conversation
when downloading a git repo the checksum doesn't work but travis still complains. how should I proceed? |
'url': 'https://github.com/deprekate', | ||
'repo_name': 'PHANOTATE', | ||
'commit': '%s' % git_commit, | ||
'recursive': True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, the installation of this is broken, because the current master
of the PHANOTATE
repo doesn't have submodules anymore.
So, the initial clone with git clone --recursive
doesn't create a fastpath
directory, and the subsequent git checkout cc42101
just leaves an empty fastpath
directory.
The subsequent git submodule update
doesn't do much, it seems like that should be git submodule update --init
to ensure the submodule gets initialized first (so that needs to be fixed in framework).
Test report by @boegel |
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 753591671 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @pescobar! |
Test report by @boegel |
(created using
eb --new-pr
)edit (by @boegel): requires fix from easybuilders/easybuild-framework#3537