Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matplotlib: Set CPLUS_INCLUDE_PATH for older matplotlib versions, newer already have it #8785

Merged
merged 4 commits into from
Aug 22, 2019
Merged

matplotlib: Set CPLUS_INCLUDE_PATH for older matplotlib versions, newer already have it #8785

merged 4 commits into from
Aug 22, 2019

Conversation

akesandgren
Copy link
Contributor

matplotlib uses CPLUS_INCLUDE_PATH to search for include files, make sure it can find freetype.

@akesandgren akesandgren added this to the next release (3.9.4?) milestone Aug 16, 2019
@Micket
Copy link
Contributor

Micket commented Aug 16, 2019

I'm going to have a hard time supplying a test report for this

@boegel boegel changed the base branch from develop to 3.9.x August 22, 2019 16:53
boegel
boegel approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, test report coming up..

@boegel
Copy link
Member

boegel commented Aug 22, 2019

Test report by @boegel
FAILED
Build succeeded for 10 out of 12 (12 easyconfigs in this PR)
node2071.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/c440ba7f53ad44fab7c56abcbc102df0 for a full test report.

@boegel
Copy link
Member

boegel commented Aug 22, 2019

Test report by @boegel
SUCCESS
Build succeeded for 12 out of 12 (12 easyconfigs in this PR)
node2018.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/f01d854af3611f17a81b7d63a8d37f79 for a full test report.

@boegel
Copy link
Member

boegel commented Aug 22, 2019

Going in, thanks @akesandgren!

@boegel boegel merged commit e0319f0 into easybuilders:3.9.x Aug 22, 2019
@akesandgren akesandgren deleted the matplotlib-set-cplus_include_path branch August 23, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

@Micket Micket Awaiting requested review from Micket

@pescobar pescobar Awaiting requested review from pescobar

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
3.9.4
Development

Successfully merging this pull request may close these issues.
3 participants
@akesandgren @Micket @boegel