Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for http:// URLs in easyconfig files added/changed in PRs #9012

Merged
merged 3 commits into from
Sep 27, 2019

Conversation

boegel
Copy link
Member

@boegel boegel commented Sep 26, 2019

works as expected, see #8999 where I squeezed in this change too by matter of proof of concept...

@boegel
Copy link
Member Author

boegel commented Sep 26, 2019

@Micket Once this is merged, tests in Travis will fail for (new/updated) PRs if easyconfigs still have http:// in them.

We may need to whitelist for some stuff where https:// doesn't work (should we auto-check if the specified URLs exist?)

@Micket
Copy link
Contributor

Micket commented Sep 26, 2019

@boegel Having looked through a bunch of them the past week, I've vaguely recall seeing at least a couple of exceptions already. I think autochecking would be a good idea before requiring it
If they aren't using https, and there is a positive response from requests.get(url, verify=True), then they should prefer it.

@boegel
Copy link
Member Author

boegel commented Sep 26, 2019

@Micket Do you happen to recall an example of an exception, to test with?

@Micket
Copy link
Contributor

Micket commented Sep 26, 2019

https://github.com/easybuilders/easybuild-easyconfigs/pull/8997/files
oh and one from you :)
https://github.com/easybuilders/easybuild-easyconfigs/pull/8990/files
which doesn't have a valid certificate, so this should cover the two basic cases

@boegel
Copy link
Member Author

boegel commented Sep 26, 2019

enhanced test works as expected, see #8999 and #9006

Micket
Micket previously approved these changes Sep 26, 2019
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

test/easyconfigs/easyconfigs.py Outdated Show resolved Hide resolved
test/easyconfigs/easyconfigs.py Outdated Show resolved Hide resolved
@wpoely86 wpoely86 merged commit 26a3f32 into easybuilders:develop Sep 27, 2019
@boegel boegel deleted the https_check branch September 27, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants