-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add check for http:// URLs in easyconfig files added/changed in PRs #9012
Conversation
@Micket Once this is merged, tests in Travis will fail for (new/updated) PRs if easyconfigs still have We may need to whitelist for some stuff where |
@boegel Having looked through a bunch of them the past week, I've vaguely recall seeing at least a couple of exceptions already. I think autochecking would be a good idea before requiring it |
@Micket Do you happen to recall an example of an exception, to test with? |
https://github.com/easybuilders/easybuild-easyconfigs/pull/8997/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
works as expected, see #8999 where I squeezed in this change too by matter of proof of concept...