{bio} [Celera Assembler aka Whole-Genome Shotgun Assembler ] (REVIEW) #960
Conversation
|
|
||
| sanity_check_paths = { | ||
| 'files': ["bin/%s" % x for x in ["bogus", "convert-fasta-to-v2.pl", "fastqAnalyze", "markUniqueUnique", | ||
| "pacBioToCA", "uidclient"]], |
There was a problem hiding this comment.
There are Perl scripts in there, why not add a Perl dependency here?
There was a problem hiding this comment.
[escobar]@login11:bin$ head -1 convert-fasta-to-v2.pl
#!/usr/bin/perl
I don't think adding perl as dependency makes any difference. Anyway I can add it if you prefer it...
There was a problem hiding this comment.
Hmm at least patch that to #!/usr/bin/env perl?
There was a problem hiding this comment.
+1 on making sure /usr/bin/env perl is used
|
Thanks @pescobar! |
|
Test report by @pforai |
|
Test report by @pforai |
|
Test report by @pforai |
|
Test report by @rjeschmi |
|
Test report by @fgeorgatos |
| } | ||
|
|
||
| moduleclass = 'bio' | ||
|
|
There was a problem hiding this comment.
@pescobar: remove empty line and address other comments
release EasyBuild v2.3.0
|
@pforai I have updated this easyconfig because based on feedback from my users it requires to keep the hardcoded path "Linux-amd64" |
pescobar
changed the title
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4873/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4913/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
| prebuildopts += 'cd samtools && make && cd .. && ' | ||
| prebuildopts += 'cd src && ' | ||
|
|
||
| files_to_copy = ["*"] |
There was a problem hiding this comment.
so, use ConfigureMake with skipsteps = ['install'] and buildininstalldir = True?
|
Test report by @boegel |
|
@pescobar: ping on remarks? |
|
@pescobar, this PR is being closed for the following reason(s): no activity for > 6 months. |
No description provided.