Pushing easyconfigs to local git repo fails in 4.5.0

[i-mtz]

After we upgraded our EasyBuild installation to 4.5.0 we have noticed that the feature we use to send the easyconfigs and build logs to an internal git repo is no longer working. We have an ssh-key for our build user that works if we do a build with a previous EasyBuild version (4.4.2 for example) but no longer works on 4.5.0. At the end of the build we get:

/scicore/home/scicore/easybuil@bc2-gl.bc2.unibas.ch's password:

There seems to be some change in the way the repositorypath configuration option is processed, which in our config is:

repositorypath=git@bc2-gl.bc2.unibas.ch:easybuild/installed_easyconfigs_tests.git

@pescobar mentioned that this commit might be related 3252979

[boegel]

@i-mtz It looks like we're not taking into account that the repositorypath value may be something totally different than a simple path value...

Can you share the output of eb --show-config with both EasyBuild 4.4.2 and 4.5.0?

[boegel]

@i-mtz @pescobar The changes made in #3893 should fix the problem you're seeing, can you confirm?

[i-mtz]

@boegel, yes, #3893 fixes the issue for us.
Thanks!

[Micket]

Another user mentioned issues and was using
ssh://git@x.x.x.edu:2222/xxx/easybuild/slurm-cluster/deployed-recipes.git
And, surely, some might be using local git repos with other usernames. I don't think path.startswith('git@') is good enough here.

[Micket]

One option would be to check with regexp if we have to modify that function without https://stackoverflow.com/questions/2514859/regular-expression-for-git-repository seems very robust.

[boegel]

How about just checking with [a-z][@:] for URL-like paths? That'll probably work just fine in practice?

[Micket]

Sure

[Micket]

Though, technically, can't you have a .ssh/config that specifies the username for you? So it's not a guarantee.

[boegel]

An alternative could perhaps be to check if the value corresponding with an existing absolute path, and if it doesn't, then don't try to "cast" it to an absolute path at all?

[akesandgren]

Isn't the problem the code in _postprocess_config (tools/options.py) where is does

        repositorypath = self.options.repositorypath
        if isinstance(repositorypath, (list, tuple)) and len(repositorypath) == 2:
            abs_path = self.get_cfg_opt_abs_path('repositorypath', repositorypath[0])
            self.options.repositorypath = (abs_path, repositorypath[1])
        else:
            path_opt_names.append('repositorypath')

that it should only do that if self.options.repository is FileRepository ? And absolutely not if it is GitRepository ?

[boegel]

that it should only do that if self.options.repository is FileRepository ? And absolutely not if it is GitRepository ?

No, because GitRepository can also be local (so specified as a path), doesn't have to be remote (specified as a URL of some kind)

[boegel]

Another way out could be to simply skip the whole make-sure-it-is-an-absolute-path business for repositorypath, since it's quite unlikely that a relative path is specified there anyway?

The changes made in #3832 were mainly to prevent silly mistakes like in #3619, but for repositorypath it's probably much less likely that it's a problem...