Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't try to ensure absolute path for path part of repositorypath #3899

Merged
merged 2 commits into from Nov 19, 2021

Conversation

boegel
Copy link
Member

@boegel boegel commented Nov 18, 2021

#3893 was an incomplete fix for #3892

The easy way out is to just leave the repositorypath value untouched (i.e. don't try to ensure it's an absolute path), which is difficult to do since it could specify the location to a remote repository in a variety of formats...

fixes #3892

@boegel boegel added the bug fix label Nov 18, 2021
@boegel boegel added this to the next release (4.5.1?) milestone Nov 18, 2021
@easybuilders easybuilders deleted a comment from boegelbot Nov 18, 2021
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartoldeman bartoldeman merged commit 6b9a88f into easybuilders:develop Nov 19, 2021
@boegel boegel deleted the repositorypath_abs_path branch November 19, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pushing easyconfigs to local git repo fails in 4.5.0
2 participants