-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recursive unload #1425
Recursive unload #1425
Conversation
software is installed in a directory specific to each toolchain, and each toolchain module extends the path. This won't work unless toolchains properly inherit (iccifort -> iimpi -> intel) and dependencies are listed appropriately in toolchains. The other required change in easyblock.py changed the order of statements written in the module file so that the 'module use' statement appears after loading the dependencies. This allows the module path to be updated in the correct order in this naming scheme.
Fixed the names...added some humour
Fixed comments from @boegel
Final deletions
sync with develop
We currently still need to expand the toolchain load because of the current lack of support for subtoolchains within the framework
…develop Conflicts: easybuild/framework/easyblock.py
Automatic reply from Jenkins: Can I test this? |
Jenkins: ok to test |
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2187/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2188/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2189/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
add unit test, fix long lines, use recursive_unload for all module_generator.load_module statements
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2191/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Going in, thanks @ocaisa! |
Allow
recursive_mod_unload
to be used within an easyconfig. This is useful in the case of toolchains and a module hierarchy where you like to ensure the hierarchy is fully depopulated when you unload a toolchain.