don't pass down 'max_ver' as keyword to fancylogger.deprecated #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok, can you add a test case that would have triggered this? |
|
@JensTimmerman good point, adding tests made me realise there was another issue in please rerereview? |
| max_ver = kwargs.pop('max_ver', None) | ||
| if max_ver is None and args: | ||
| max_ver = args[0] | ||
| args = args[1:] |
There was a problem hiding this comment.
you have no way to know that max_ver will be args[0], so please don't do this, if you expect it,
make the function definition
def deprecated(self, msg, ver, max_ver=None,*args, **kwargs):
`
boegel
changed the title
|
looks good to me |
|
Thanks for the review @JensTimmerman! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have been part of #1896...
@JensTimmerman please review?