Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dump a fully parsed easyconfig to the reproducibility dir in all cases #2574

Merged
merged 5 commits into from
Sep 13, 2018
Merged

Dump a fully parsed easyconfig to the reproducibility dir in all cases #2574

merged 5 commits into from
Sep 13, 2018

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented Sep 11, 2018

Fixes #2565

@ocaisa
Copy link
Member Author

ocaisa commented Sep 11, 2018

Hmm, not so simple, this is kicking a ton of errors with the tests.

@boegelbot

This comment has been minimized.

Sign in to view
@boegelbot

This comment has been minimized.

Sign in to view
@boegel boegel added this to the 3.7.0 milestone Sep 11, 2018
@boegel
Copy link
Member

boegel commented Sep 11, 2018

@ocaisa The only 3 failing tests are the ones that involve .yeb easyconfigs, so it's more an issue with those tests imho...

@ocaisa
Copy link
Member Author

ocaisa commented Sep 12, 2018

@akesandgren Can you review this, it's a minor change

boegel
boegel previously requested changes Sep 12, 2018
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense, just some minor suggestions

easybuild/framework/easyblock.py Outdated Show resolved Hide resolved
easybuild/framework/easyblock.py Outdated Show resolved Hide resolved
@ocaisa ocaisa dismissed boegel’s stale review September 13, 2018 09:32

Ready for final look

@boegel boegel merged commit 3e6f4ad into easybuilders:develop Sep 13, 2018
@boegel boegel mentioned this pull request Sep 13, 2018
Closed
@ocaisa ocaisa deleted the reprod_dumping branch September 13, 2018 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ocaisa @boegelbot @boegel