Use requests instead of urllib2 for 403 errors. #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3 error. requests comes to the rescue there too.
bartoldeman
changed the title
|
@bartoldeman Can we cover this in the tests? See |
|
@bartoldeman Now blocked because of a merge conflict, please sync with current Let me know if you need help by covering this in the tests. |
|
@bartoldeman Ping on making this ready to go, maybe include in EasyBuild v3.9.1 (window is closing...) |
|
@bartoldeman Pinging again... |
|
ok, will have another look. |
Conflicts: easybuild/tools/filetools.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NASM has this issue. requests comes to the rescue there too.