Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix running of 'easyconfigparser' and 'format_convert' test suites with Python 3 #2778

Merged
merged 1 commit into from Feb 21, 2019

Conversation

boegel
Copy link
Member

@boegel boegel commented Feb 20, 2019

This is mainly about fixing the Wrapper class so it also works with Python 3, but I also stripped out a bunch of stuff that we no longer use (see Patch* and ListOfStrings & co) since some of those tests were failing on top of Python 3.
It was non-trivial to fix those tests, and there's little point anyway in fixing something that is no longer used...
The Wrapper class is still used for the Dependency class (via Convert), so that part is definitely still relevant (for now...).

@boegel boegel added the python3 Python 3 compatibility label Feb 20, 2019
@boegel boegel added this to the 4.0 milestone Feb 20, 2019
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah metaclasses, so much fun there is to be had. I don't completely understand it at first (it's been a long time since I was so deeply into Python classes), but it looks ok, so I will approve.

@bartoldeman bartoldeman merged commit 24dea4e into easybuilders:4.x Feb 21, 2019
@boegel boegel deleted the py3_wrapper_fixes branch February 21, 2019 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python3 Python 3 compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants