Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepend location of test easyblocks to $PYTHONPATH to test_generate_software_list, rather than append #2788

Merged
merged 1 commit into from
Feb 25, 2019
Merged

prepend location of test easyblocks to $PYTHONPATH to test_generate_software_list, rather than append #2788

merged 1 commit into from
Feb 25, 2019

Conversation

boegel
Copy link
Member

@boegel boegel commented Feb 25, 2019

test_generate_software_list fails when easybuild-easyblocks repo is also included in $PYTHONPATH

@boegel boegel added the bug fix label Feb 25, 2019
@boegel boegel added this to the next release (3.8.2) milestone Feb 25, 2019
migueldiascosta
migueldiascosta approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit 793e799 into easybuilders:develop Feb 25, 2019
@boegel boegel deleted the fix_scripts_test branch February 25, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @migueldiascosta