Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

also copy template values in EasyConfig.copy method to ensure they are defined when installing extensions #3377

Merged
merged 3 commits into from
Jul 4, 2020
Merged

also copy template values in EasyConfig.copy method to ensure they are defined when installing extensions #3377

merged 3 commits into from
Jul 4, 2020

Conversation

boegel
Copy link
Member

@boegel boegel commented Jul 3, 2020 •
edited
Loading

This fixes #3317, see #3317 (comment) for more details.

Before merging, I want to cover this in the tests properly... done!

@boegel boegel added the bug fix label Jul 3, 2020
@boegel boegel added this to the 4.2.2 milestone Jul 3, 2020
@boegel boegel changed the title also copy template values in EasyConfig.copy method also copy template values in EasyConfig.copy method to ensure they are defined when installing extensions Jul 3, 2020
bartoldeman
bartoldeman previously requested changes Jul 4, 2020
View reviewed changes
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with just a typo to fix. Good catch!

test/framework/easyconfig.py Outdated Show resolved Hide resolved
zao
zao approved these changes Jul 4, 2020
View reviewed changes
Copy link
Contributor

@zao zao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bartoldeman
bartoldeman approved these changes Jul 4, 2020
View reviewed changes
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartoldeman bartoldeman merged commit 7fd37c0 into easybuilders:develop Jul 4, 2020
@boegel boegel deleted the easyconfig_copy_template_values branch July 4, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zao zao zao approved these changes

@bartoldeman bartoldeman bartoldeman approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.2.2
Development

Successfully merging this pull request may close these issues.

Templates not being resolved in exts_list
3 participants
@boegel @zao @bartoldeman