-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve handling of start_dir and add tests for cases where either ext_dir or initial start_dir or both are unset or None #4206
Conversation
Python packages may be installed from WHL files which do not get extracted in which case `self.start_dir, self.ext_dir` are both `None`. This leads to an unhelpful warning: > WARNING: Provided start dir (None) for extension tensorboard-plugin-wit does not exist:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I suggest to update the description of _set_start_dir
to reflect the new logic
Also add a test for the case where `ext_dir` is unset but start_dir exists.
This may confuse e.g. `os.path.dirname`
605cfd5
to
194b1f3
Compare
As discussed with @Flamefire, these are the target outcomes for
1: might be done by some custom easyblock, cannot be handled as we do not know the base dir The result will be that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test report with this PR and the Overview of tested easyconfigs (in order)
|
Going in, thanks @Flamefire ! |
Python packages may be installed from WHL files which do not get extracted in which case
self.start_dir, self.ext_dir
are bothNone
. This leads to an unhelpful warning:Check that case and only log a debug message. Also add test for this.
Note that #4196 changed semantics: Prior to this
start_dir
orext_dir
where used if set and existing resolved relative to the current directory. After thatstart_dir
is resolved relative toext_dir
which is usually the same but does not need to.