add minimal set of bash functions required to make tab completion work for 'older' versions of bash #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -92,7 +92,7 @@ def find_rel_test(): | |||
| packages = easybuild_packages, | |||
| package_dir = {'test.framework': "test/framework"}, | |||
| package_data = {"test.framework": find_rel_test()}, | |||
| scripts = ["eb", "optcomplete.bash"], | |||
| scripts = ["eb", "optcomplete.bash", "minimal_bash_completion.bash"], | |||
There was a problem hiding this comment.
maybe add them with data_files? should be done for vsc-base too i guess
There was a problem hiding this comment.
You don't have (full) control for the stuff in data_files where it is installed too, e.g. with:
data_files = [
('easybuild', ["easybuild/easybuild_config.py"]),
('share', ["optcomplete.bash", "minimal_bash_completion.bash"]),
],you get:
$ python setup.py install --prefix /tmp/ebv110devtest
$ ls /tmp/ebv110devtest/lib/python2.7/site-packages/easybuild_framework-1.10.0dev-py2.7.egg/share/
minimal_bash_completion.bash optcomplete.bash
…lled alongside 'eb' command
|
@stdweird: OK to go in? |
|
yes, please open an issue in vsc-base to investigate better location and mechanism for the .bash files; for now it will do just fine. |
|
@stdweird: done, see hpcugent/vsc-base#99 |
|
merging this, so we'll have decent tab completion support in EB v1.10! |
boegel
added a commit
that referenced
this pull request
Dec 17, 2013
add minimal set of bash functions required to make tab completion work for 'older' versions of bash
|
@boegel thx., but let's not call this decent. all it does for now is option completion, there is no value completion yet |
|
that's decent, not ideal ;) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
documentation to set this up available at https://github.com/hpcugent/easybuild/wiki/Setting-up-tab-completion-for-bash