fix type of return value of extra_options as it was before, enhance unit tests #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stdweird: please review? |
| extra = dict(extra) | ||
|
|
||
| # to avoid breaking backward compatibility, we still need to return a list of tuples in EasyBuild v1.x | ||
| return extra.items() |
There was a problem hiding this comment.
actually returning a list itself should also deprecated. dunno if we can access the deprecation logic that easy.
There was a problem hiding this comment.
I can do something like this:
self.log.deprecated("return list of tuples rather than a dict") # FIXME proper log message
res = extra.items()
return resWould that be sufficient?
There was a problem hiding this comment.
yes, if you use _log.deprecated(..., '2.0')
|
@stdweird: fixed remarks |
|
Jenkins is happy, so merging this in, thanks for the review @stdweird! |
boegel
added a commit
that referenced
this pull request
Mar 25, 2014
fix type of return value of extra_options as it was before, enhance unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.