Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eb does not throw an error if sources are missing #534

Open
cmeesters opened this issue Aug 1, 2019 · 1 comment
Open

eb does not throw an error if sources are missing #534

cmeesters opened this issue Aug 1, 2019 · 1 comment
Milestone

Comments

@cmeesters
Copy link

Hi,

when there are no sources in a particular easyconfig (e.g. a typo in the sources or source url lists) eb states in the log that nothing could be found, proceeds and throws an error upon the sanity check stage. That merits improvement, doesn't it?

I would like eb to abort when there are zero valid sources.

Opinions?

Best regards,
Christian

@boegel boegel added this to the 3.x milestone Aug 6, 2019
@boegel
Copy link
Member

boegel commented Aug 6, 2019

@cmeesters There are situations where having no sources at all is valid, for example when installing a toolchain (see the easyconfigs in https://webappsx.ugent.be/eventManager/events/pretrefopenfoamhpc) or when installing a bundle (see for example https://github.com/easybuilders/easybuild-easyconfigs/blob/master/easybuild/easyconfigs/g/GCC/GCC-9.1.0-2.32.eb).

That said, this doesn't mean there isn't any room for improvement, since most installations do involve a non-empty sources list, of course...

Maybe we could print a warning when sources is empty, and simply silence that warning when either the Toolchain, Bundle or PythonBundle easyblocks are used?

@boegel boegel modified the milestones: 3.x, 4.x Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants