-
Notifications
You must be signed in to change notification settings - Fork 702
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
2 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16c0c85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ryanbr! This effectively broke all
navigator.sendBeacon
requests, whether they're used for tracking purposes or not. In particular, it broke quite a lot of functionality in app.hey.com is a mail service app with no ads or tracking of any kind. For example, we usesendBeacon
to mark emails as read when you're reading them. This is now blocked by this very broad rule that's surely breaking other features across all sorts of web apps.Could this please be reverted? Happy to open an issue if necessary.
16c0c85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ryanbr! I wanted to echo what @rosa said:
For kialo.com and kialo-edu.com we also use
sendBeacon
to mark content as read as you're reading it. We also don't have any kind of ads or tracking.As @rosa said, I imagine this rule breaks other sites as well. Maybe you could consider reverting it?
If you want to keep it, could you add
kialo.com
andkialo-edu.com
to the exceptions as you did forhey.com
in ec763daf61c3?Thanks a lot!
16c0c85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't want to revert completely, could you limit the block for third-party requests? For
sendBeacon
requests to the origin, this is not preventing any kind of tracking that could be already being done via regular requests, just breaking functionality if the app happens to use this, which is perfectly legit and not related to tracking.16c0c85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filter has been adjusted to third-party.
16c0c85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryanbr Great thanks, our site works again. Thanks a lot for the quick reaction!
16c0c85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🎉 🎉