Skip to content

Commit

Permalink
M: Block ping by default
Browse files Browse the repository at this point in the history
  • Loading branch information
@ryanbr
ryanbr committed Jan 5, 2022
1 parent 7501796 commit 16c0c85
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions easyprivacy/easyprivacy_trackingservers.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2796,6 +2796,8 @@
||ztsrv.com^$third-party
||zuyapixel.com^$third-party
||zuzab.com^$third-party
! Block ping
$ping
! https://www.opensubtitles.org/
$third-party,xmlhttprequest,domain=opensubtitles.org
! https://blog.confiant.com/the-trend-of-client-side-fingerprinting-in-cloaked-landing-pages-21915eb473df
Expand Down

6 comments on commit 16c0c85

@rosa
Copy link

@rosa rosa commented on 16c0c85 Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ryanbr! This effectively broke all navigator.sendBeacon requests, whether they're used for tracking purposes or not. In particular, it broke quite a lot of functionality in app.hey.com is a mail service app with no ads or tracking of any kind. For example, we use sendBeacon to mark emails as read when you're reading them. This is now blocked by this very broad rule that's surely breaking other features across all sorts of web apps.

Could this please be reverted? Happy to open an issue if necessary.

@mg-kialo
Copy link

@mg-kialo mg-kialo commented on 16c0c85 Jan 10, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ryanbr! I wanted to echo what @rosa said:

For kialo.com and kialo-edu.com we also use sendBeacon to mark content as read as you're reading it. We also don't have any kind of ads or tracking.

As @rosa said, I imagine this rule breaks other sites as well. Maybe you could consider reverting it?

If you want to keep it, could you add kialo.com and kialo-edu.com to the exceptions as you did for hey.com in ec763daf61c3?

Thanks a lot!

@rosa
Copy link

@rosa rosa commented on 16c0c85 Jan 10, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't want to revert completely, could you limit the block for third-party requests? For sendBeacon requests to the origin, this is not preventing any kind of tracking that could be already being done via regular requests, just breaking functionality if the app happens to use this, which is perfectly legit and not related to tracking.

@ryanbr
Copy link
Member Author

@ryanbr ryanbr commented on 16c0c85 Jan 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filter has been adjusted to third-party.

@mg-kialo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanbr Great thanks, our site works again. Thanks a lot for the quick reaction!

@rosa
Copy link

@rosa rosa commented on 16c0c85 Jan 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉 🎉

Please sign in to comment.