Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xHamster sites - Broken (Easylist Cookie List / Fanboy's Annoyance List) [GDPR] #12011

Closed
THEtomaso opened this issue May 13, 2022 · 14 comments
Closed

Comments

@THEtomaso
Copy link

THEtomaso commented May 13, 2022

Affected sites:

https://xhamster.com/ [NSFW]

(and a bunch of mirrors)

Issue:

Elements won't load properly, due to a blocked cookie consent, which now needs to be accepted!

Screenshot:

Not needed, as the problem is obvious.

Problem filters:

  • Easylist Cookie List
  • Fanboy's Annoyance List

Problem rule:

##.cookies-modal:not(body):not(html)

Possible fix (for uBO):

xhamster.*,xhamster1.*,xhamster11.*,xhamster2.*,xhamster5.*,xhamster7.*#@#.cookies-modal:not(body):not(html)

(At least, this should cover some of the known mirrors, but there are many more)

--

System info:

  • OS/version: Windows 10 Pro (x64)
  • Browser/version: Pale Moon v29.4.6 (x64)
  • Adblock Extension/version: uBlock Origin v1.16.4.30 (XUL)
@ryanbr
Copy link
Member

ryanbr commented May 13, 2022

We don't use wildcards, also tested https://xhamster2.com/ no issues. Get a "parential" overlay (which can be skipped), but other than that, no issues.

@THEtomaso
Copy link
Author

We don't use wildcards

Does this mean that ABP-support is back on the table for your cookie filter?
..because several of the fixes that you've applied for it lately has contained uBO-only syntaxes.
E.g. these:
#10035 (comment)
#10330 (comment)
#10397 (comment)

--

Get a "parential" overlay (which can be skipped)

Yes, exactly, but there's no obvious button to press!
A whitelisting will eliminate the confusion.

@Yuki2718
Copy link
Collaborator

@Yuki2718
Copy link
Collaborator

Wildcard => maybe exapand to .com and .desi.

@THEtomaso
Copy link
Author

@Yuki2718:

This rule needs to be disabled in uBO Legacy, in order to see the logical-to-click cookie dialog again!:

AdguardTeam/AdguardFilters@a5047c6#diff-4242d8ca02b02c727d49f104f6a755388e5713822779c8b08aa1bdc29061305eR7252

@Yuki2718
Copy link
Collaborator

@THEtomaso Is adding megaxh.com,xhwide1.com,xhamster16.*,hamsterix.*,xhplanet1.com,xhamster13.*,xhamster18.*,xhamster19.*,xhamster11.*,xhamster5.*,xhamster10.*,xhamster4.*,xhamster3.*,xhamster2.*,xhamster.*#@#.cookies-modal to legacy enough?

@THEtomaso
Copy link
Author

Yes.
I disabled it like this though, which also worked:
megaxh.com,xhwide1.com,xhamster16.*,hamsterix.*,xhplanet1.com,xhamster13.*,xhamster18.*,xhamster19.*,xhamster11.*,xhamster5.*,xhamster10.*,xhamster4.*,xhamster3.*,xhamster2.*,xhamster.*#@$#.cookies-modal { display: none !important; }

@Yuki2718
Copy link
Collaborator

Well, AG Annoyances is not default list but there's no way to exclude only legacy on AG side. I have to ask what to do to other members.

@THEtomaso
Copy link
Author

Guess it can be added to uBO's Legacy filter, unless you've got a better idea.

Yuki2718 added a commit to uBlockOrigin/uAssets that referenced this issue May 14, 2022
@THEtomaso
Copy link
Author

THEtomaso commented May 14, 2022

uBlockOrigin/uAssets@0189e86 👍

Might just as well add this one too:

megaxh.com,xhwide1.com,xhamster16.*,hamsterix.*,xhplanet1.com,xhamster13.*,xhamster18.*,xhamster19.*,xhamster11.*,xhamster5.*,xhamster10.*,xhamster4.*,xhamster3.*,xhamster2.*,xhamster.*#@#.cookies-modal:not(body):not(html)

..to fix the same issue, caused by Easylist Cookie List.

@Yuki2718
Copy link
Collaborator

Yuki2718 commented May 14, 2022

If I understand correctly, it also matters to ABP so should be fixed in ELC (with additional rules to its uBO sublist for non-legacy). Does the uBO sublist also affects legacy?

Yuki2718 added a commit to uBlockOrigin/uAssets that referenced this issue May 14, 2022
@Yuki2718
Copy link
Collaborator

(temp) fixed anyway as the site is popular.

@THEtomaso
Copy link
Author

Like I pointed out in my second post; I'm somewhat confused about ryanbr's policy in regards to keeping ELCL ABP-compatible.
Need to hear what he has to say about it.

@ryanbr
Copy link
Member

ryanbr commented May 22, 2022

Reviewed it on FF and Chrome, seems pretty minor. Happy to leave it since there is an easy work around (literally click anywhere on the screen and it'll show the content)

@ryanbr ryanbr closed this as completed May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants