-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(): refine declare #1148
fix(): refine declare #1148
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1148 +/- ##
==========================================
- Coverage 84.11% 83.59% -0.53%
==========================================
Files 469 471 +2
Lines 13709 14151 +442
Branches 2010 2149 +139
==========================================
+ Hits 11532 11829 +297
- Misses 1764 1896 +132
- Partials 413 426 +13
|
🚀 Deployed on https://docs-preview-1148--next-bricks.netlify.app |
bricks/vs/src/code-editor/index.tsx
Outdated
@property({ | ||
type: Boolean, | ||
}) | ||
accessor enableCustomValidationInBrickNextYaml: boolean | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
属性有点太长,enable
属于比较多余的
accessor enableCustomValidationInBrickNextYaml: boolean | undefined; | |
accessor customValidationInBrickNextYaml: boolean | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
依赖检查
组件之间的依赖声明,是微服务组件架构下的重要信息,请确保其正确性。
请勾选以下两组选项其中之一:
或者:
提交信息检查
Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG,请检查工作内容与提交信息是否相符,并在以下每组选项中都依次确认。
破坏性变更:
feat
作为提交类型。BREAKING CHANGE: 你的变更说明
。新特性:
feat
作为提交类型。问题修复:
fix
作为提交类型。杂项工作:
即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动,例如修改注释、测试用例、开发文档等:
chore
,docs
,test
等作为提交类型。