-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): add Style schema and fix code editor default emit event #1166
feat(): add Style schema and fix code editor default emit event #1166
Conversation
c1dbfc3
to
ee64a48
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1166 +/- ##
==========================================
- Coverage 84.07% 83.35% -0.72%
==========================================
Files 476 483 +7
Lines 14175 14170 -5
Branches 2118 2090 -28
==========================================
- Hits 11917 11812 -105
- Misses 1826 1926 +100
Partials 432 432
|
🚀 Deployed on https://docs-preview-1166--next-bricks.netlify.app |
Co-authored-by: Shenwei Wang <wangshenwei@qq.com>
bricks/vs/src/code-editor/index.tsx
Outdated
@@ -429,6 +432,8 @@ export function CodeEditorComponent({ | |||
break; | |||
} | |||
} | |||
|
|||
setIsEditing(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个 worker message 跟 editing 有什么关系?而且貌似只有 brick_next_yaml 才有,其他的没有
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已干掉这个逻辑,改有新逻辑代替,onChange 现在是同步模式,不在 parseYaml 里面触发;
parseYaml 现在只触发 user.input 逻辑。
557859d
to
9e0ba14
Compare
依赖检查
组件之间的依赖声明,是微服务组件架构下的重要信息,请确保其正确性。
请勾选以下两组选项其中之一:
或者:
提交信息检查
Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG,请检查工作内容与提交信息是否相符,并在以下每组选项中都依次确认。
破坏性变更:
feat
作为提交类型。BREAKING CHANGE: 你的变更说明
。新特性:
feat
作为提交类型。问题修复:
fix
作为提交类型。杂项工作:
即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动,例如修改注释、测试用例、开发文档等:
chore
,docs
,test
等作为提交类型。