Use type hints in Seraliser classes #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 5.3 supports type hinting so there is almost no reason to implement type checks. Corresponding unit tests are also not necessary. SerialiserTest is for the Serialiser class, not MockSerialiser. Therefore we must treat $this->serialiser as an instance of Serialiser and not MockSerialiser.
njh
added a commit
that referenced
this pull request
Nov 1, 2015
Use type hints in Seraliser classes
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #255 I reorganised my commits. This pull request is only for type hints in Serialiser class tree.