Implement LIBXML_PARSEHUGE #294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel-KM
reviewed
Oct 30, 2018
| @@ -159,6 +159,13 @@ public function testParseFile() | |||
| $this->assertSame(null, $name->getDatatype()); | |||
| } | |||
|
|
|||
| public function testParseLargeFile() | |||
There was a problem hiding this comment.
Can you remove the tabs on all this function? It prevents Travis check.
Suggested change
| public function testParseLargeFile() | |
| public function testParseLargeFile() | |
| { | |
| $graph = new Graph(); | |
| $count = $graph->parseFile(fixturePath('stw.rdf')); | |
| $this->assertSame(109340, $count); | |
| } |
Daniel-KM
reviewed
Oct 30, 2018
|
|
||
| $resource = fopen('data://text/plain,' . $data, 'r'); | ||
|
|
||
| while ($data = fread($resource, 1024 * 1024)) { |
There was a problem hiding this comment.
You said you test it on a 150 MB xml, but is it a one line xml or a multiline one? If this is a one line (or that contains lines bigger than 1024 x 1024 characters, does it work fine?
|
What is the status here? |
|
This pull request should be merged. Failing test is because of a timeout, please restart test suite. Ref: #320 |
k00ni
added a commit
to k00ni/easyrdf
that referenced
this pull request
Jul 6, 2020
These changes were contributed by @zozlak on my fork: https://github.com/sweetyrdf/easyrdf/pull/16 There was a code change in the meantime, in comparison to easyrdf/easyrdf::master. It was merged from easyrdf#294. It introduced the `fopen` call when loading XML file. Co-authored-by: Mateusz Żółtak <zozlak@zozlak.org> Co-authored-by: Konrad Abicht <hi@inspirito.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing files > 10mb results in
"XML error: No memory"regardless of PHPmemory_limitsettings. Using LibXML'sLIBXML_PARSEHUGEparam and chunking up the XML data as a resource in a loop fixes (Tested on a 150mb RDF).