RDFXML parser crashes any character sequences decoded by the urldecode() #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes were contributed by @zozlak on my fork: https://github.com/sweetyrdf/easyrdf/pull/16 There was a code change in the meantime, in comparison to easyrdf/easyrdf::master. It was merged from easyrdf#294. It introduced the `fopen` call when loading XML file. Co-authored-by: Mateusz Żółtak <zozlak@zozlak.org> Co-authored-by: Konrad Abicht <hi@inspirito.de>
Added further code, which was added before the code of the related pull request, because expected working test fails: https://travis-ci.com/github/k00ni/easyrdf/jobs/357965728#L804 Parsed value is empty.
…erty call in failing test The source of the failing test may be located in easyrdf#292 because these changes are not yet part of easyrdf/easyrdf's master branch.
|
Closed in favor of #352. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these changes were contributed by @zozlak on my fork: https://github.com/sweetyrdf/easyrdf/pull/16
But there were code changes in the meantime, in comparison to easyrdf/easyrdf::master. They came from a merge of #294 and introduced the
fopencall when loading a XML file. The code of @zozlak was based on these changes.#294 also introduced
LIBXML_PARSEHUGEwhen calling$doc->loadXML. These changes are not part of this PR, but should be merged too.Ignore my comments in commit ff11f4d, I made a mistake by mentioning changes from #292 which should be part of this PR. They are not. The fix already works by using surrounding
<and>in the failing test case.To be honest, it became harder to keep a clear view with all the code changes in different forks. I vote for merging this and #294, except @zozlak intervenes (see next section below). That would clear the field. If we don't merge this PR, then #294 should be closed too.
@zozlak: It would be great if you could help me out here by answering https://github.com/sweetyrdf/easyrdf/pull/16#issuecomment-654257216. Thank you in advance!