Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LICENSE to MIT #300

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Change LICENSE to MIT #300

merged 1 commit into from
Sep 20, 2023

Conversation

bwiernik
Copy link
Contributor

We are systematically re-licensing easystats packages to use the MIT licence, to make our package licences as clear and permissive as possible. To do so, we need the approval of all copyright holders (people who contributed any amount of non-trivial code), which I have found by reviewing contributions from all non-easystats contributors.

The only commit to this repository by someone outside the easystats team is 6593f70, which I would regard as an important but trivial bug fix.

So I think we are safe to merge. WDYT @IndrajeetPatil?

We are systematically re-licensing easystats packages to use the MIT licence, to make our package licences as clear and permissive as possible. To do so, we need the approval of all copyright holders (people who contributed any amount of non-trivial code), which I have found by reviewing contributions from all non-easystats contributors.

The only commit to this repository by someone outside the easystats team is 6593f70, which I would regard as an important but trivial bug fix.

So I think we are safe to merge. WDYT @IndrajeetPatil?
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #300 (d79d608) into main (d54855d) will not change coverage.
The diff coverage is n/a.

❗ Current head d79d608 differs from pull request most recent head 564703a. Consider uploading reports for the commit 564703a to get more accurate results

@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   70.00%   70.00%           
=======================================
  Files          44       44           
  Lines        2054     2054           
=======================================
  Hits         1438     1438           
  Misses        616      616           

Copy link
Member

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree. IMHO, it's not significant enough of a contribution to merit securing an approval from them for change of licence.

@IndrajeetPatil IndrajeetPatil merged commit 0b1a700 into main Sep 20, 2023
13 of 26 checks passed
@IndrajeetPatil IndrajeetPatil deleted the relicense branch September 20, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants