Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move .get_dot_data() toWIP folder #64

Closed
IndrajeetPatil opened this issue Feb 13, 2022 · 4 comments · Fixed by #65
Closed

Move .get_dot_data() toWIP folder #64

IndrajeetPatil opened this issue Feb 13, 2022 · 4 comments · Fixed by #65
Labels
question Further information is requested

Comments

@IndrajeetPatil
Copy link
Member

@strengejacke Can this be removed? It's not used anywhere, either in this package or the larger ecosystem.

https://github.com/easystats/datawizard/blob/c99114587b05b074a043991a3a80ee66ab6d26e1/R/utils_get_dots.R
@IndrajeetPatil IndrajeetPatil added the question Further information is requested label Feb 13, 2022
IndrajeetPatil added a commit that referenced this issue Feb 13, 2022
@IndrajeetPatil
closes #64
a6ca947
@strengejacke
Copy link
Member

I think we added this as a draft for implementing select helpers. I recall @bwiernik suggested adding this feature, I think it was related to the use of the drop and keep arguments in parameters.

@strengejacke
Copy link
Member

We could move it to a WIP folder, maybe?

@bwiernik
Copy link
Contributor

Yes, that was the plan

@IndrajeetPatil IndrajeetPatil changed the title Remove .get_dot_data() Move .get_dot_data() toWIP folder Feb 13, 2022
@IndrajeetPatil IndrajeetPatil linked a pull request Feb 13, 2022 that will close this issue
closes #64 #65
Merged
IndrajeetPatil added a commit that referenced this issue Feb 13, 2022
@IndrajeetPatil
closes #64 (#65)
b38e207 
* closes #64

* move utils dots to WIP folder
@IndrajeetPatil
Copy link
Member Author

These functions now live in WIP folder.

IndrajeetPatil added a commit that referenced this issue Feb 13, 2022
@IndrajeetPatil
increasing code coverage (#66)
e36198b 
* convert_data_to_numeric

* closes #64 (#65)

* closes #64

* move utils dots to WIP folder

* data_findcols

* convert_data_to_numeric

* data_findcols

* data_addprefix

* data_partition

* data_match; more data_partition

* data_relocate

* data_rescale

* data_reshape

* describe_distribution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

closes #64 easystats/datawizard
3 participants
@bwiernik @IndrajeetPatil @strengejacke