perf: refresh highlight on change

eatgrass · Jan 3, 2024 · f128dcf · f128dcf
1 parent 1b13ca4
commit f128dcf
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/LyricsMarkdownRender.ts b/src/LyricsMarkdownRender.ts
@@ -76,16 +76,16 @@ export default class LyricsMarkdownRender extends MarkdownRenderChild {
         }
 
         if (!this.pauseHl) {
-            if (this.currentHL >= 0) {
-                let hlels = this.container.findAll('.lyrics-highlighted')
-                hlels.forEach((el) => {
+            //remove highlight
+            lyrics.forEach((el, index) => {
+                if (index !== hl) {
                     el.removeClass('lyrics-highlighted')
-                })
-            }
+                }
+            })
 
             if (hl >= 0) {
                 const hlel = lyrics.item(hl)
-                if (hlel) {
+                if (hlel && !hlel.hasClass('lyrics-highlighted')) {
                     hlel.addClass('lyrics-highlighted')
                     if (this.autoScroll) {
                         hlel.scrollIntoView({