-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setHue does not work for Groups #1
Comments
Thanks for your comments! This looks like an asynchronous execution timing issue: the this.bridge.request callback in setHue comes in after setSat is fired from homekit so setSat computes xy using the old homekit hue value. Recalling a scene or setting a favourite colour probably changes the homekit saturation quicker after changing the hue than the colour wheel does. Group commands to the hue bridge are like 10x more expensive than light commands, so the callback comes later. Indeed, the structural solution would be to collect the hue and sat changes into one bridge update (and one computation of xy). Not sure about the (lack of) elegance of your workaround, though. As the homekit value has changed, it seems correct to update homebridge-hue's cache of the homekit state, regardless whether updating the Hue bridge state succeeds or not. |
Thanks @ebaauw :-) |
"If You're Not Embarrassed By The First Version Of Your Product, You’ve Launched Too Late" I've been struggling with the homebridge-hue plug-in logic dealing with homekit values vs hue bridge values and how to update these. Just putting down my thoughts, mainly for myself. The main logic
The issue: rounding errors Colours: worse than rounding errors Colormode
Closing remarks
|
@dgburton : I just pushed version 0.0.7 to npm, which, I hope, solved this issue. |
Thank you! |
Thanks for your work on this plugin!
I'm trying to use it to control Groups (as I've got quite a few Hue bulbs I breach the 100-devices per bridge Homekit limit if I add each bulb individually).
Everything seems to work fine apart from setting the Hue of the Group. Whenever I set the Hue either via a Scene or recalling a favourite color (using the iOS10 Home app) it fails. Dragging around the colour wheel does seem to work fine.
The text was updated successfully, but these errors were encountered: