Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homebridge ZP doesn't handle zone player with changed IP address #137

Closed
ebaauw opened this issue May 16, 2020 · 1 comment
Closed

Homebridge ZP doesn't handle zone player with changed IP address #137

ebaauw opened this issue May 16, 2020 · 1 comment
Labels
bug

Comments

@ebaauw
Copy link
Owner

ebaauw commented May 16, 2020 •
edited

From Discord.

Hacked cachedAccessories to give my Bathroom zone players an "old" IP address (.177 instead of .77). Upon restart:

[5/16/2020, 8:43:38 PM] [Sonos] Bathroom: cached Master v1.0.29 RINCON_949F3E0E142C01400: {"name":"Bathroom","id":"RINCON_949F3E0E142C01400","address":"192.x.x.177"}
[5/16/2020, 8:43:38 PM] [Sonos] RINCON_949F3E0E142C01400 [192.x.x.177]: probing (1 jobs)...
[5/16/2020, 8:43:38 PM] [Sonos] RINCON_949F3E0E142C01400 [192.x.x.177]: request 1: GET /xml/device_description.xml]
...
[5/16/2020, 8:43:38 PM] [Sonos] upnp: found RINCON_949F3E0E142C01400 at 192.x.x.77
...
[5/16/2020, 8:44:56 PM] [Sonos] error: RINCON_949F3E0E142C01400 [192.x.x.177]: 192.168.76.177:1400: cannot connect: ETIMEDOUT
[5/16/2020, 8:44:56 PM] [Sonos] RINCON_949F3E0E142C01400 [192.x.x.177]: probing failed (0 jobs remaining)
...
[5/16/2020, 8:44:56 PM] [Sonos] error: RINCON_949F3E0E142C01400 [192.x.x.177]: cannot initialise zone player
[5/16/2020, 8:44:56 PM] [Sonos] warning: RINCON_949F3E0E142C01400 [192.x.x.177]: now at 192.168.76.77
...
[5/16/2020, 8:44:56 PM] [Sonos] initialised
[5/16/2020, 8:44:56 PM] [Sonos] Bathroom: remove stale Master v1.0.29 accessory RINCON_949F3E0E142C01400
[5/16/2020, 8:44:56 PM] [Sonos] Bathroom: remove Master RINCON_949F3E0E142C01400
...
[5/16/2020, 8:46:45 PM] [Sonos] RINCON_949F3E0E142C01400 [192.x.x.77]: probing (1 jobs)...
[5/16/2020, 8:46:45 PM] [Sonos] RINCON_949F3E0E142C01400 [192.x.x.77]: request 2: GET /xml/device_description.xml
[5/16/2020, 8:48:02 PM] [Sonos] error: RINCON_949F3E0E142C01400 [192.x.x.77]: 192.x.x.177:1400: cannot connect: ETIMEDOUT
[5/16/2020, 8:48:02 PM] [Sonos] RINCON_949F3E0E142C01400 [192.x.x.77]: probing failed (0 jobs remaining)
[5/16/2020, 8:48:02 PM] [Sonos] error: RINCON_949F3E0E142C01400 [192.x.x.77]: cannot initialise zone player

The last five messages repeat.

So Homebridge ZP does recognise that the zone player has a new IP address, but somehow it sticks to the old address. Moreover, it deletes the stale accessory. Upon restart, the zone player is (re-)discovered and exposed as new accessory.
@ebaauw ebaauw changed the title Homebridge ZP doesn't expose zone player with changed IP address Homebridge ZP doesn't handle zone player with changed IP address May 16, 2020
ebaauw added a commit that referenced this issue May 16, 2020
@ebaauw
Update ZpClient.js
2e5fb35 
Renew `HttpClient` when zoneplayer has new IP address, see #137.
ebaauw added a commit that referenced this issue May 16, 2020
@ebaauw
Update ZpPlatform.js
769c8dd 
Check for new IP address when restored zone player is re-discovered.  See #137.
@ebaauw ebaauw added the bug label May 17, 2020
@ebaauw
Copy link
Owner Author

ebaauw commented May 17, 2020

Fixed in v1.0.30.

@ebaauw ebaauw closed this as completed May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ebaauw