Make HTTP requests using curl with fallback to file stream #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparK-Cruz
suggested changes
Feb 15, 2017
| throw new \RuntimeException('allow_url_fopen must be enabled to use PHP streams.'); | ||
| } | ||
| } | ||
| return null; |
There was a problem hiding this comment.
Code by gravity. Use guard clauses and avoid if elseif pyramids.
SparK-Cruz
approved these changes
Feb 15, 2017
SparK-Cruz
suggested changes
Feb 15, 2017
| $response = json_decode($response); | ||
| } | ||
| } else { | ||
| if(curl_errno($this->curl)) { |
There was a problem hiding this comment.
There are a few weird responses that don't use 200, in case of api business rules validations.
The ignoredStatusCodes array was built to filter them out.
SparK-Cruz
approved these changes
Feb 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.