Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpay gateway #538

Merged
merged 5 commits into from
Jul 21, 2017
Merged

Webpay gateway #538

merged 5 commits into from
Jul 21, 2017

Conversation

andercampanha
Copy link
Contributor

No description provided.

return $this->process_response_error($request, $order);
}
$redirect = $request->redirect_url;
if (!$redirect && !$request->payment->redirect_url) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace !$request->payment->redirect_url with !isset($request->payment->redirect_url)

*/
public function is_available()
{
return parent::is_available() && $this->getTransactionAddress('country') == WC_EBANX_Constants::COUNTRY_CHILE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always use ===


parent::__construct();

$this->enabled = is_array($this->configs->settings['chile_payment_methods']) ? in_array($this->id, $this->configs->settings['chile_payment_methods']) ? 'yes' : false : false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Break some lines to make it pretty :bowtie:

Copy link
Contributor

@cezarsmpio cezarsmpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@andercampanha andercampanha merged commit 8ff5ffe into develop Jul 21, 2017
@andercampanha andercampanha deleted the feature/chile-webpay-gateway branch July 21, 2017 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants