Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic on date overflow #71

Merged
merged 2 commits into from
Oct 23, 2021
Merged

Conversation

5225225
Copy link
Contributor

@5225225 5225225 commented Oct 2, 2021

No description provided.

@ebarnard
Copy link
Owner

Both of the new tests looks to be failing (and the plists parsing successfully)?

@5225225
Copy link
Contributor Author

5225225 commented Oct 21, 2021

It seems to be a version issue?

cargo +stable test passes the tests

cargo +1.40.0 test fails. Not to say that the code isn't wrong, but it's something strange going on. That or caching weirdness?

I develop with nightly so I never spotted that. (I also somewhat forgot about this PR, sorry!).

I'll have a look tonight to see if I can figure out what's going on.

@ebarnard ebarnard merged commit 2ea4cf0 into ebarnard:master Oct 23, 2021
@5225225 5225225 deleted the date-overflow branch October 23, 2021 20:04
@ebarnard
Copy link
Owner

Released in v1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants