Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wundef warnings on Windows #114

Closed
lazka opened this issue Apr 8, 2018 · 5 comments
Closed

-Wundef warnings on Windows #114

lazka opened this issue Apr 8, 2018 · 5 comments
Assignees
@ebassi
Labels
build

Comments

@lazka
Copy link
Contributor

lazka commented Apr 8, 2018

Building gtk4 on Windows which uses -Wundef results in lots of warnings (see https://gitlab.gnome.org/creiter/gtk/-/jobs/21892):

C:/msys64/mingw32/lib/graphene-1.0/include/graphene-config.h:15:27: warning: "_M_IX86_FP" is not defined, evaluates to 0 [-Wundef]
 # if defined(__SSE__) || (_M_IX86_FP > 0) || (_M_X64 > 0) || (_MSC_VER >= 1800)
                           ^~~~~~~~~~
C:/msys64/mingw32/lib/graphene-1.0/include/graphene-config.h:15:47: warning: "_M_X64" is not defined, evaluates to 0 [-Wundef]
 # if defined(__SSE__) || (_M_IX86_FP > 0) || (_M_X64 > 0) || (_MSC_VER >= 1800)
                                               ^~~~~~
C:/msys64/mingw32/lib/graphene-1.0/include/graphene-config.h:15:63: warning: "_MSC_VER" is not defined, evaluates to 0 [-Wundef]
 # if defined(__SSE__) || (_M_IX86_FP > 0) || (_M_X64 > 0) || (_MSC_VER >= 1800)
                                                               ^~~~~~~~
ebassi added a commit that referenced this issue Apr 9, 2018
@ebassi
Check if symbols are defined before using them
33008d2 
The C pre-processors symbols we are using to decide whether SSE builtins
are available need to be checked for being defined, before we can use
them in comparisons.

Fixes #114
@ebassi ebassi mentioned this issue Apr 9, 2018
Merged
@ebassi ebassi self-assigned this Apr 9, 2018
@ebassi ebassi added the build label Apr 9, 2018
@ebassi
Copy link
Owner

ebassi commented Apr 9, 2018

It would be nice to have a MSVC compiler flag to catch the equivalent of -Wundef as well.

@lazka
Copy link
Contributor Author

lazka commented Apr 9, 2018

I could add a MSYS2 job to appveyor if you want.

@ebassi
Copy link
Owner

ebassi commented Apr 9, 2018

@lazka The MSYS2 job would be appreciated as well. Did PR #115 work?

@lazka
Copy link
Contributor Author

lazka commented Apr 9, 2018

@lazka The MSYS2 job would be appreciated as well

ok, added to my list

Did PR #115 work?

Yes, build output: https://bpaste.net/show/5108f78c1a5e

@ebassi
Copy link
Owner

ebassi commented Apr 9, 2018

Thanks!

I see other issues in that build log; would you mind filing them as well?

ebassi added a commit that referenced this issue Apr 9, 2018
@ebassi
Check if symbols are defined before using them
939c273 
The C pre-processors symbols we are using to decide whether SSE builtins
are available need to be checked for being defined, before we can use
them in comparisons.

Fixes #114
@lazka lazka mentioned this issue Apr 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebassi ebassi

Labels
build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ebassi @lazka