Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs: long text end of line - new line starts with the arrow #79

Closed
hramakumar opened this issue Apr 4, 2018 · 14 comments
Closed

Comments

@hramakumar
Copy link

hramakumar commented Apr 4, 2018

Added the new component to the ebayui test env page
When I use long text to fill the line- the new line starts with the arrow

expected behavior- The new line takes in the last word with it

http://go/ebayuitest

screenshot attached

@hramakumar
Copy link
Author

pls look at the last line

@hramakumar
Copy link
Author

arrow

@hramakumar
Copy link
Author

hramakumar commented Apr 5, 2018

  1. The leaf node goes to the next line - Raja will fix it
  2. Is ok for a new line to start with an arrow?-question to the design team

@RajaRamu
Copy link
Contributor

RajaRamu commented Apr 5, 2018

PR is open - eBay/skin#130

@hramakumar
Copy link
Author

hramakumar commented Apr 5, 2018

the fix broke mweb styling(looks fine in desktop)
screenshot_2018-04-05-01-03-36

@ianmcburnie
Copy link
Contributor

ianmcburnie commented Apr 5, 2018

@hramakumar Which piece is broken? It's not immediately apparent from that screenshot. Can you provide a before and after?

@RajaRamu are you testing on mobile?

@ianmcburnie ianmcburnie changed the title breadcrumbs- long text end of line- new line starts with the arrow Breadcrumbs: long text end of line - new line starts with the arrow Apr 5, 2018
@hramakumar
Copy link
Author

breadcrumbs with leaf node as text look bigger that the ones with leaf as links

@hramakumar
Copy link
Author

hramakumar commented Apr 5, 2018

  1. compare the first one"element with last page as current" and "element until end of line". the font size is different.
  2. Also if you look at "breadcrumb-two element" leaf element goes to the new line.

@ianmcburnie
Copy link
Contributor

@RajaRamu Can you investigate & provide more information on whether this is expected or not.

@hramakumar
Copy link
Author

I downgraded to skin version 3.5.1 and this issue goes away.
It has something to do with the skin upgrade 3.5.2(fix version)

@hramakumar
Copy link
Author

hramakumar commented Apr 6, 2018

actual behavior

skin_3 5 2

expected behavior

skin-3 5 1

@ianmcburnie
Copy link
Contributor

@RajaRamu Can you please investigate.

@RajaRamu
Copy link
Contributor

RajaRamu commented Apr 6, 2018

Yes. i will have to test it mobile devices. i will check it out in device lab. thanks

@ianmcburnie
Copy link
Contributor

Original issue was resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants