Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb wrapping Issue - 79 #130

Merged
merged 4 commits into from
Apr 5, 2018
Merged

Breadcrumb wrapping Issue - 79 #130

merged 4 commits into from
Apr 5, 2018

Conversation

RajaRamu
Copy link
Contributor

@RajaRamu RajaRamu commented Apr 5, 2018

Description

Arrow is not wrapping properly along long text.

Context

If any item has long text and gets wrapped into multiple lines, arrows is standing off.

References

eBay/ebayui-core#79

Screenshots

Before:

before

After

after

@seangates
Copy link
Contributor

Is there a reason you're using your own repo and creating a PR to this branch? You should probably just commit directly to the 3.5.2 branch.

@ianmcburnie
Copy link
Contributor

ianmcburnie commented Apr 5, 2018

@RajaRamu Can you please add a screenshot of before and after behaviour, to help us understand the issue and fix.

@ianmcburnie ianmcburnie added this to the 3.5.2 milestone Apr 5, 2018
@RajaRamu RajaRamu merged commit 49f6487 into eBay:3.5.2 Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants