Switch to draft-06 #48
Conversation
| |[`skeemas`](https://github.com/Prestaul/skeemas#readme)|[221](https://github.com/ebdrup/json-schema-benchmark/blob/master/reports/skeemas.md)| | ||
| |[`schemasaurus`](https://github.com/AlexeyGrishin/schemasaurus)|[222](https://github.com/ebdrup/json-schema-benchmark/blob/master/reports/schemasaurus.md)| | ||
| |[`json-gate`](https://github.com/oferei/json-gate#readme)|[312](https://github.com/ebdrup/json-schema-benchmark/blob/master/reports/json-gate.md)| | ||
| |[`revalidator`](https://github.com/flatiron/revalidator)|[355](https://github.com/ebdrup/json-schema-benchmark/blob/master/reports/revalidator.md)| |
There was a problem hiding this comment.
This is a very strange result. Baseline () => true returns 358 failing, revalidator returns 355 failing.
There was a problem hiding this comment.
Well, same on master: () => true -- 285 failures, revalidator -- 277 failures.
Not this PR fault.
There was a problem hiding this comment.
I think this list can be pruned a bit - no much point keeping the bottom of the list. Also I am surprised djv fails so many tests - it was relatively compliant. I think it might be some API issue we could fix.
|
Switching to draft-06 would also allow me to switch to the latest version of Ajv - it should pass all draft-06 tests and might be even faster (I was actually trying to benchmark it when I realised ajv v7 no longer supports draft-04. @ebdrup unless have any strong objections, I think we should merge it - I can do it in a couple of weeks if you won't comment... |
|
@ChALkeR we could add vue-vuelidate-jsonschema and Hyperjump JSV - they support draft-06 (https://json-schema.org/implementations.html) - could you maybe add to PR? |
|
Hi @ChALkeR Sorry, I've had all my GitHub notifications turned off. I made you a collaborator to the repo. I think the idea of running the benchmark for draft 6 is great. Note: I just updated the test runner so the benchmark now automatically includes the top 6 validators that fail the least tests. Feel free to tweak that number to be the top 7, 8, ... if you want to have some of the faster validators still included. |
draft-04is significantly outdated.Note how this increases conformance on up-to-date validators.
This is half-issue, PR just to include the code if you decide to do this.
Wdyt?
Unfortunately, this also excludes
is-my-json-validandz-schemafrom the benchmark results.Perhaps this can be made a separate branch as an easy way to keep track of the per-spec status without major changes to this repo? With a simple menu in header to switch between branches?
Same could be done for draft-07 and draft2019-09 then. #40 is related.
Tests run can be force-pushed out -- included just to demonstrate test result differences.