jsonContext.toJson(o, generator, path) can not apply path on @Transient field that is an entity bean

[icode]

class Model {
String a;
@Transient
List<ModelB> list;
}
Model model = findById(1);
model.list = find(ModelB.class).select("oneField").findList();
//path -> (a,list(oneField))
jsonContext.toJson(o, generator, path)
//-> {"a":"a",list:[{"oneField":1,"twoField":null}]} should not show `twoField`

[icode]

Hello @rbygrave ?

[rbygrave]

Hello
On 21 Dec 2015 5:55 pm, "icode" notifications@github.com wrote:

�Hello @rbygrave https://github.com/rbygrave ?

—
Reply to this email directly or view it on GitHub
#502 (comment)
.

[icode]

Haha, you are funny! @rbygrave This is a bug or issue?

[rbygrave]

I had a quick look and it didn't make sense to me. If you want to update it so that it makes more sense I'll have another look.

[icode]

on jax-rs , i give a fields params (a,list(oneField)), but can not filter Transient field

[icode]

jackson module call jsonContext.toJson(o, generator, path) i give it path

[icode]

Or other function filter @Transient field？

[icode]

@rbygrave Are you understand ?

[rbygrave]

No, this does not make sense. There is no explanation of what 'twoField' is nor "oneField" ... neither are in the model where you are trying to explain the issue.

[rbygrave]

o, generator and path ... are also not defined in your example code.

[icode]

@Test
public void testTransientPath() throws Throwable {
    ModelA modelA = Ebean.find(ModelA.class, 1);
    modelA.list = Ebean.createQuery(ModelB.class).select("oneField").findList();
    String json = Ebean.json().toJson(modelA, PathProperties.parse("(a,list(oneField))"));
    Assert.assertEquals(json, "{\"a\":\"a\",\"list\":[{\"oneField\":1}]}");
 }

@Entity
class ModelA {
    String a;
    @Transient  // it's not has mapping, but client need result
    List<ModelB> list;
}

@Entity
class ModelB {
    Integer oneField;
    Integer twoField;
}

[icode]

@rbygrave please see test case, understand ?

[rbygrave]

Very close. You now just need to state:

1. which assert fails
2. what your expectation is ... "I expected json to contain <...> but what I instead saw was that it instead contained <...>"

[icode]

I want this Assert.assertEquals(json, "{\"a\":\"a\",\"list\":[{\"oneField\":1}]}"); success.
twoField should not in json string

[icode]

now , @Transient field not apply PathProperties in toJson.

[rbygrave]

It would be clear if you state exactly what the value of json is. Specifically the first assertNotEquals() passing is confusing me.

[icode]

ok, i change it. are you understand?

[rbygrave]

It would be clear if you state exactly what the value of json is.

[icode]

//path -> (a,list(oneField))

json {"a":"a","list":[{"oneField":1}]}

[rbygrave]

What is wrong with that? It is the same as the assertEquals ... so you are saying the assert does not fail?

Assert.assertEquals(json, "{\"a\":\"a\",\"list\":[{\"oneField\":1}]}");

[icode]

I get {"a":"a",list:[{"oneField":1,"twoField":null}]}

[icode]

import com.avaje.ebean.Ebean;
import com.avaje.ebean.EbeanServer;
import com.avaje.ebean.EbeanServerFactory;
import com.avaje.ebean.config.DataSourceConfig;
import com.avaje.ebean.config.ServerConfig;
import com.avaje.ebean.text.PathProperties;
import com.google.common.collect.Lists;
import org.avaje.agentloader.AgentLoader;
import org.h2.Driver;
import org.junit.Assert;
import org.junit.Test;

import javax.persistence.Entity;
import javax.persistence.Id;
import javax.persistence.Transient;
import java.io.IOException;
import java.lang.instrument.IllegalClassFormatException;
import java.util.List;

/**
 * @author icode
 */
public class EbeanTest {

    @Test
    public void JsonTest() throws IOException, IllegalClassFormatException, ClassNotFoundException {
        AgentLoader.loadAgentFromClasspath("avaje-ebeanorm-agent", "debug=5");
        final ServerConfig config = new ServerConfig();
        config.setClasses(Lists.<Class<?>>newArrayList(ModelA.class, ModelB.class));
        DataSourceConfig dataSourceConfig = new DataSourceConfig();
        dataSourceConfig.setUrl("jdbc:h2:file:./db");
        dataSourceConfig.setDriver(Driver.class.getName());
        dataSourceConfig.setUsername("sa");
        dataSourceConfig.setPassword("");
        config.setDataSourceConfig(dataSourceConfig);
        config.setName("default");
        config.setDdlGenerate(true);
        config.setDdlRun(true);
        config.setDefaultServer(true);
        EbeanServer server = EbeanServerFactory.create(config);
        ModelA a = new ModelA();
        a.setId(1);
        a.setA("a");
        server.save(a);
        ModelB b = new ModelB();
        b.setOneField(1);
        b.setTwoField(1);
        server.save(b);
        ModelA sa = server.find(ModelA.class, 1);
        sa.setList(server.find(ModelB.class).findList());
        String json = Ebean.json().toJson(sa, PathProperties.parse("(a,list(oneField))"));
        Assert.assertEquals(json, "{\"a\":\"a\",\"list\":[{\"oneField\":1}]}");
    }

    @Entity
    public static class ModelA {
        @Id
        int id;
        String a;
        @Transient  // it's not has mapping, but client need result
                List<ModelB> list;

        public String getA() {
            return a;
        }

        public void setA(String a) {
            this.a = a;
        }

        public List<ModelB> getList() {
            return list;
        }

        public void setList(List<ModelB> list) {
            this.list = list;
        }

        public int getId() {
            return id;
        }

        public void setId(int id) {
            this.id = id;
        }
    }

    @Entity
    public static class ModelB {
        Integer oneField;
        Integer twoField;

        public Integer getOneField() {
            return oneField;
        }

        public void setOneField(Integer oneField) {
            this.oneField = oneField;
        }

        public Integer getTwoField() {
            return twoField;
        }

        public void setTwoField(Integer twoField) {
            this.twoField = twoField;
        }
    }
}

this is clear test case! thanks test it!

[icode]

can fix it? @rbygrave thanks

[rbygrave]

Running this test produces:

org.junit.ComparisonFailure:
Expected :{"a":"a","list":[{"oneField":1,"twoField":1}]}
Actual :{"a":"a","list":[{"oneField":1}]}

Hmm, there is no null there.

[rbygrave]

BeanPropertyAssocMany line 891. transient properties written via the Jackson ObjectMapper ... so that means there is for example no check that the target type is actually an entity bean. This is probably the issue.

[rbygrave]

Right, the fix was that for transient ToMany properties to also check the targetDescriptor to see if they are entity beans (in which case we can keep processing with the built in JSON processing rather than use Jackson ObjectMapper).