Possible memory leak with BackgroundExecutor using BackgroundExecutorWrapper ThreadLocals (for scheduled tasks) #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rPraml
reviewed
Oct 17, 2022
| } | ||
|
|
||
| @Override | ||
| public ScheduledFuture<?> schedule(Runnable task, long delay, TimeUnit unit) { | ||
| return schedulePool.schedule(wrap(logExceptions(task)), delay, unit); |
There was a problem hiding this comment.
I'm not sure, if we should keep it here. The task will be scheduled one time. But this may keep objects also long in memory.
Maybe the caller is responsible to pass a proper runnable/callable
There was a problem hiding this comment.
I'm not sure either - it almost looks like a 50/50 call to me.
If we do wrap() here it would be a problem if the delay is "a long time", and if that is a problem for a particular use case then what is the workaround? I don't see a nice workaround so that is suggesting to me that we don't wrap() here [and leave it up to the caller to wrap or not].
rbygrave
approved these changes
Oct 17, 2022
|
Hello @rbygrave , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @rbygrave ,
hello @rPraml ,
I created a PR with the fix of #2854.
Could you please check it?
@rbygrave the maven build does not work local on my machine,
CsvReaderTestthrows ajava.time.format.DateTimeParseException: Text '01-Jan-2009' could not be parsed at index 3.The test works only if I use
-Duser.language="en".Cheers
Noemi