Add a visual UI distinction for anndata experiments in the gene search results #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ke4
requested changes
Feb 6, 2023
| { | ||
| experimentAccession.substring(0,6) === ANNDATA ? | ||
| //tbc | ||
| <img src={`https://user-images.githubusercontent.com/33519183/203308460-aee477fa-c8ab-4561-be46-34254bfa1731.png`} /> : |
There was a problem hiding this comment.
This is not the final icon, right?
I think @alfonsomunozpomer has the final one. We should probably put @alfonsomunozpomer 's one into the resources folder and use it.
| @@ -58,7 +66,7 @@ class ExperimentCard extends React.Component { | |||
| } | |||
|
|
|||
| render() { | |||
| const {url, species, experimentDescription, markerGenes, numberOfAssays, factors} = this.props | |||
| const {url, species, experimentDescription, markerGenes, numberOfAssays, experimentAccession, type, factors} = this.props | |||
There was a problem hiding this comment.
I might miss something, but I can't see that the experimentAccession and type is being added to the propTypes. Am I wrong?
lingyun1010
deleted the
scxa-faceted-search-result/feature/127-add-a-visual-ui-distinction-for-anndata-experiments-in-the-gene-search-results
branch
lingyun1010
restored the
scxa-faceted-search-result/feature/127-add-a-visual-ui-distinction-for-anndata-experiments-in-the-gene-search-results
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gene search result card added a new column to experiment type icon to distinguish anndata and the others. A tooltip is added if users hover on the icon. This is not a src code implementation, so there is no new test for it. Our component is compatible with new header and card style.