This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
Feature #160722817 – Add search examples below the search box #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lingyun1010
reviewed
Nov 23, 2018
| links.map( | ||
| (link, index) => | ||
| <span key={index}> | ||
| {index === 0 && ` `}<a href={link.url}>{link.text}</a>{index < links.length - 1 && `, `} |
There was a problem hiding this comment.
The last link should not be followed by a comma I believe.
There was a problem hiding this comment.
It won’t be, notice that the right hand side is links.length -1 instead of links.length.
There was a problem hiding this comment.
The comma is shown on the SC homepage actually.
There was a problem hiding this comment.
It's weird since I try the same test searchExamples data in the local search form branch, which works fine. However, it appears differently on the atlas branch.
There was a problem hiding this comment.
Oh, yes, that’s because the bundles were from the penultimate release. If you generate the bundles yourself and try it out it’ll be ok.
lingyun1010
approved these changes
Nov 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we need more flexibility we can let the client insert a full React component, but for the current story this is enough, I guess.