This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
Feature/163976247 add download button marker #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
json payload parameter `name` into `geneName` to avoid confusion between gene name and x-axis name.
viewdata and highchart cloud
alfonsomunozpomer
suggested changes
Apr 25, 2019
There was a problem hiding this comment.
Besides reverting the geneName change in the error object, let’s do at least some minimum testing by verifying that menuItems in the Highcharts component contains downloadCSV and downloadXLS. Notice you don’t need to mount the component, shallowly checking with Enzyme will suffice.
Additionally, getHeatmapExportDataModule doesn’t tell me much about its functionality. Can you think of a better name? Lastly, add this file to the set of ignored files by Jest for coverage since it’s third party code.
alfonsomunozpomer
approved these changes
Apr 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSV and XLS export options are added on the heatmap right corner dropdown menu. The default
export-datamodule is based on data (series.data), not on SVG output. The solution is provided by Highcart Group. A transpose applied to the output data is implemented to match the view on heatmap. Please review this PR with atlas-web-single-cell.