Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

Feature/163976247 add download button marker #2

Merged
merged 9 commits into from
Apr 30, 2019

Conversation

lingyun1010
Copy link
Contributor

CSV and XLS export options are added on the heatmap right corner dropdown menu. The default export-data module is based on data (series.data), not on SVG output. The solution is provided by Highcart Group. A transpose applied to the output data is implemented to match the view on heatmap. Please review this PR with atlas-web-single-cell.

Copy link
Member

@alfonsomunozpomer alfonsomunozpomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides reverting the geneName change in the error object, let’s do at least some minimum testing by verifying that menuItems in the Highcharts component contains downloadCSV and downloadXLS. Notice you don’t need to mount the component, shallowly checking with Enzyme will suffice.

Additionally, getHeatmapExportDataModule doesn’t tell me much about its functionality. Can you think of a better name? Lastly, add this file to the set of ignored files by Jest for coverage since it’s third party code.

src/HeatmapView.js Outdated Show resolved Hide resolved
src/HeatmapView.js Outdated Show resolved Hide resolved
Copy link
Member

@alfonsomunozpomer alfonsomunozpomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Note how coverage has slightly increased. 👍

@lingyun1010 lingyun1010 merged commit d0da4eb into master Apr 30, 2019
@lingyun1010 lingyun1010 deleted the feature/163976247-add-download-button-marker branch April 30, 2019 08:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants