-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polymer 1.x #6
Comments
Yea. Theres a WIP branch. On Sun, Jul 5, 2015, 12:46 PM Matthias H. Risse notifications@github.com
|
Thanks! |
@ebidel I downloaded the V1.X build and get |
You'll need to |
@ebidel Ok Thanks. I figured there was some kinda new age sorcery going on in there which i didn't know about :~) BTW it works well in the 'dist' directory after gulp however there is one small bug. In dist\index.html the script tag still looks for |
Hmm, it shouldn't: https://github.com/ebidel/polymer-gmail/blob/1.0/index.html#L199. I would kill and unregister any service worker in |
https://poly-mail.appspot.com/ now serves the Polymer 1.0 version! I did a quick comparison on WPT to see the difference from the Polymer 0.5 version of the app. TL;DR:
ResultsSmaller numbers are better in all cases. Chrome desktop - cable connection
Analysis: 1.0 w/ lazy loading reduced FP by 943 ms and SI by 56.94%. FF desktop - cable connection
Analysis: interestingly, on a desktop polyfill'd browser like FF, both SI and FP increased when switching to the lazy loading technique. However, both 1.0 versions beat the Polymer 0.5 app. Motorola G - Chrome - 3G Fast connection
Repeat view - Load time: 3.30s, First paint: 589 ms, Speed index: 2627 Analysis: FP got better (negligible 1.55%). SI reduced by ~29%. However, when introducing lazy loading to the 1.0 app, FP reduced by ~4.14s (71% saving) and SI by 39%** compared to the 0.5 app. Repeat view is even more impressive (FP ~590ms and SI of 2627) thanks to offline caching and Service worker. ConclusionsIn all cases, Polymer 1.0 is faster than 0.5. Also, lazy loading the polyfills and HTML imports on the page is a big win, esp. on slower mobile connections. I purposefully neglected to discuss page load time. For this app, the slower bits that push the waterfall out are due to non-Polymer related things: Google Fonts API, Google JS Client library loads and rpc iframes, Google Analytics. Notes
|
🎉 Great job! |
@ebidel sorry its the other way round, index.html points to bundle.js at https://github.com/ebidel/polymer-gmail/blob/1.0/index.html#L199 but the scripts folder has app.js https://github.com/ebidel/polymer-gmail/tree/1.0/scripts; ofcourse this issue does not occur in dist folder because of browserify. However i mostly use app folder for studying the code & run from app folder in chrome dev tools. |
Tried running the new https://poly-mail.appspot.com/ , sign in went through fine but emails did not load; got the below error in console. |
@devAtPolydeals I don't have a good solution for running it under dev without compiling atm. app.js will need to be compiled to bundle.js and the app run from dist/. I need to setup watch tasks to get things working in dev. That error is probably around https://github.com/ebidel/polymer-gmail/blob/1.0/scripts/googleapis.js#L124-L127. Something is different about some of your email threads. Would love to know more. |
@ebidel I would love to help but don't know how? It is tough to debug it with minified js and I cannot run uniminified on localhost because of googleapi does not allow access from localhost. BTW ?debug switch gives 404 because users.json is not available.
|
@devAtPolydeals try replacing the Google client ID with your own (which must have GMail read access and optionally G+ read access). |
@devAtPolydeals, ack on users.json. It's a known issue. I need to upload a list of folks...that aren't my actual contacts :p |
Merged the code into master. Closing this. |
@ebidel Excellent example. Any plans to upgrade this to use v1.x?
The text was updated successfully, but these errors were encountered: