Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Channel Configurable #112

Closed
ghickman opened this issue Sep 7, 2020 · 0 comments
Closed

Make Channel Configurable #112

ghickman opened this issue Sep 7, 2020 · 0 comments

Comments

@ghickman
Copy link
Contributor

ghickman commented Sep 7, 2020

As part of #110 we would have preferred to emit messages to not-#general. However, to do that in the webhook handler we would have had to let it know more directly about the webhooks/projects it handles or couple it to job configs.

The preferable solution is to make channel a configurable option for a job and have a scheduled task look that up when it gets run, rather than storing it in the job table.

evansd added a commit that referenced this issue Feb 7, 2024
I think this closes #112 but I don't know if OpenCodelists is still
deployed in this way.
@evansd evansd closed this as completed in 6307292 Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant