Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert on missing presentations #2322

Closed
evansd opened this issue Dec 16, 2019 · 2 comments
Closed

Alert on missing presentations #2322

evansd opened this issue Dec 16, 2019 · 2 comments

Comments

@evansd
Copy link
Contributor

evansd commented Dec 16, 2019

Sometimes we have prescribing recorded against BNF codes for which we have no corresponding entry in our Presentations table (1106000AKBBABAB, a form of eye drop, is an example at time of writing.)

The root of this issue is (we're pretty confident) that there's been a change in BNF codes but we don't have a copy of the latest BNF code mapping file (see #380). We've requested an up-to-date copy.

It would be good to check automatically for future instances of this problem. Probably this would be best done as an import pipeline step. It needn't block import of the data but it would be good to know about the issue as soon as possible.

The alert should include information on what to do next i.e. who to email at NHSBSA, which file to request, and what to do with it once we have it.

evansd added a commit that referenced this issue Dec 16, 2019
This should be a rare and temporary situation. See #2322
@richiecroker
Copy link
Collaborator

@evansd can we close this - we seem to handle it ok now

@evansd
Copy link
Contributor Author

evansd commented Aug 8, 2023

Yeah, I don't know if this is fully addressed but I'm confident we're not going to do anything about it now!

@evansd evansd closed this as completed Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants