New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map BNF code changes to current codes #380
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These code changes are based on a list provided as a spreadsheet by NHS BSA.
These were expressed wrongly in the spreadsheet we were supplied.
This speeds things up mightily
Using this view should guarantee all codes are normalised to their most recent representation.
Unfortunately necessary as a query and a view must both use the same SQL flavour, and we use both because of different support for different features in the respective flavours.
We might as well keep it in, as we'll only ever have to run any of this command again if there's another major BNF release.
...because we don't currently import them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These code changes are based on a list provided as a spreadsheet by NHS
BSA.
Fixes #214
Also fixes #253 and fixes #342
Before this is closed, we should also make a list of codes we know to have changed within a year, and supply them to BSA as a query.