-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show when entities are closed on their homepage #1727
Conversation
This fixes part of #889. |
Can we make the text stand out a bit more? e.g. "CLOSED: 16 May 2018" or use red maybe? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I think it would be fine to wrap it in a <span class="text-danger">
if @HelenCEBM thinks that would be helpful, but from my own point of view it's OK as it is.
Here it is wrapped in a What do you think @HelenCEBM? |
Yes great thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. In case you've not noticed, you appear not to have pushed the red styling.
Pushed now. |
👍 Looks good to me |
Practice:
Regional team: