Merging in React-Select v5.1 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confusion about Typescript arises because the HEAD of the current master branch, although still numbered v4.x for the npm-published module, still shoes the Typescript code to be releases as v5. Unfamiliar users might assume that, variously, v4.x is written in Typescript (in fact, it's in JavaScript) or that the typings in this code work for v4.x (they don't, as they're not compatible with the required `@types` version. These 2 statements should clear up confusion.
For the uninitiated, some possible points of confusion about Typescript and React Select are solved with these 2 short sentences. There will be no need to edit them in the future... or, at least until there is no demand for v4. BACKGROUND: For the current HEAD of master, the version number in the `package.json` is v4.x and all code is written in Typescript, although Typescript code will not be published until v5. A reasonable inference, if not the only one possible, is that v4 ships with the `.d.ts` files that reflect this Typescript code, especially since the `package.json` for v4.2.3 indicates that they do. Additionally, absent clarification, a user might assume that the typings on the current master apply to v4. In fact, they are incompatible with the @types version.
'#'=0 '$'=96145 '*'=( ) -=569Xils '?'=0 @=( ) ARGC=0 HISTCMD=1033 LINENO=33 PPID=96144 TTYIDLE=1 ZSH_EVAL_CONTEXT=toplevel:cmdsubst ZSH_SUBSHELL=1 builtins funcstack status=0 terminfo zsh_eval_context=( toplevel cmdsubst ) attribute when as it causes problems with screen readers.
Remove AutoSizeInput
Refactor how the DummyInput works when isSearchable={false}
Update README to clarify need for @types for v4 and not for v5
Changeset for v5 beta
Version Packages (beta)
Add TypeScript guide to website
Allow loadingMessage prop to return any ReactNode
Add type for CreateOptionActionMeta `option` field
…arse-1.5.3 Bump url-parse from 1.5.1 to 1.5.3
Exit prerelease mode
Version Packages
* Fix "Props" documentation page not loading types * Downgrade `clean-webpack-plugin` to `3.0.0`
* Add template chooser configuration * Update issue template * Prettier * Add v5 Sandbox
* Export more types from main entry point * Create nice-hounds-buy.md * Update nice-hounds-buy.md * Format * Export just as type * Update types.ts * Update nice-hounds-buy.md
…4803) * Import CSSObject from @emotion/react instead of @emotion/serialize * Create honest-crabs-judge.md * Format * Add csstype resolution
* fix: input was moved to the left due to space char * chore: add changeset file * fix: input display on a new line when using multi select * fix: change whitespace from `nowrap` to `pre` to preserve whitespace
* Set ValueContainer display grid if isMulti and has no value * Prettified
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/daaku/nodejs-tmpl/releases) - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) --- updated-dependencies: - dependency-name: tmpl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Remove src directory from published package
…1.0.5 Bump tmpl from 1.0.4 to 1.0.5
* Add missing index prop on MultiValue * Create small-bobcats-push.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.